impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3245: Fix crash with global filters when NUM_NODES=1
Date Tue, 05 Apr 2016 22:12:03 GMT
Henry Robinson has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/2721

Change subject: IMPALA-3245: Fix crash with global filters when NUM_NODES=1
......................................................................

IMPALA-3245: Fix crash with global filters when NUM_NODES=1

This patch disables global filters when NUM_NODES=1, to avoid a crash
where the UpdateFilter() path expected a CountingBarrier to be set up
which was only initialised on the multi-backend path.

Alternative approaches include downgrading the global filters to local
ones (since there's only one fragment), but the complexity in return for
the performance gain does not seem worth it for this relatively
little-used feature.

Change-Id: I7b9a6bcc64ca6ec5fd51d63815cea25de866ef93
---
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M testdata/workloads/functional-query/queries/QueryTest/runtime_filters.test
3 files changed, 18 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/21/2721/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7b9a6bcc64ca6ec5fd51d63815cea25de866ef93
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Henry Robinson <henry@cloudera.com>

Mime
View raw message