impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Armstrong <tarmstr...@cloudera.com>
Subject Re: [Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation
Date Tue, 26 Apr 2016 03:24:51 GMT
Sounds like useful coverage, although nightly might even be overkill.

On Mon, Apr 25, 2016 at 8:22 PM, Casey Ching (Code Review) <
gerrit@cloudera.org> wrote:

> Casey Ching has posted comments on this change.
>
> Change subject: Kudu: Exclude non-Kudu symbols during stub client
> generation
> ......................................................................
>
>
> Patch Set 1:
>
> > didn't he say it occurred while executing some BE tests. He may
>  > have had something wrong with his setup, but having a private build
>  > succeed on a supported and non-supported OS seems like it would be
>  > the minimum coverage we should have. The customer cluster test is a
>  > good idea too. Or can we just write a BE test that calls into it?
>
> Ah you are right, the be tests failed.
>
> What do you guys think about just setting up a nightly rhel 5 job? It
> would be nice to have coverage there anyhow and its really simple to do. I
> can set it up.
>
> --
> To view, visit http://gerrit.cloudera.org:8080/2864
> To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
>
> Gerrit-MessageType: comment
> Gerrit-Change-Id: I54292095692ce38c255a8df48cf8f3f655d797b0
> Gerrit-PatchSet: 1
> Gerrit-Project: Impala
> Gerrit-Branch: cdh5-trunk
> Gerrit-Owner: Casey Ching <casey@cloudera.com>
> Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
> Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
> Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
> Gerrit-HasComments: No
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message