impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <>
Subject [Impala-CR](cdh5-trunk) IMPALA-3159: Enable SAN / wildcard certificate support in shell
Date Sat, 30 Apr 2016 05:56:50 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-3159: Enable SAN / wildcard certificate support in shell

Patch Set 1:

File be/src/testutil/wildcard-cert.pem:

Line 1: -----BEGIN CERTIFICATE-----
Looking at the contents of the cert, it looks to be valid only for a month... The tests probably
will fail after that.

bharath@optimus:~/Impala/be/src/testutil$ openssl x509 -in wildcard-cert.pem -text -noout
        Version: 3 (0x2)
        Serial Number: 11455138221987083059 (0x9ef8d3855e8a3333)
    Signature Algorithm: sha256WithRSAEncryption
        Issuer: C=US, ST=CA, L=SF, O=Cloudera, CN=*/
            Not Before: Apr 29 18:47:19 2016 GMT
---->            Not After : May 29 18:47:19 2016 GMT   <-------
File tests/custom_cluster/

Line 1: 2012

Line 15: Tests for query expiration.
Not relevant

Line 34: SSL is enabled
Better to make it a constant? Repeated multiple times. (Others below too).

Line 63:                                     "--ssl_private_key=%s/server-key.pem"
Should there be a test for password protected private key too? (be/src/testutil/server-key-password.pem)
File tests/shell/

Line 83: run_impala_shell_cmd
Should this go into tests/util/ ? The current file seems to be a test file.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie47d6e02fc856b73f531b6ac49b1bab0976a8396
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Henry Robinson <>
Gerrit-Reviewer: Bharath Vissapragada <>
Gerrit-HasComments: Yes

View raw message