impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Skye Wanderman-Milne (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-1578: fix text scanner to handle "\r\n" delimiters split across blocks
Date Sat, 30 Apr 2016 01:17:20 GMT
Skye Wanderman-Milne has posted comments on this change.

Change subject: IMPALA-1578: fix text scanner to handle "\r\n" delimiters split across blocks
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2803/4/be/src/exec/delimited-text-parser.cc
File be/src/exec/delimited-text-parser.cc:

Line 281: 
I think this was originally intended to return no delimiter found if the buffer ends in '\r',
but it both doesn't implement this correctly (buffer_start[tuple_start] is the character *after*
the delimiter), and we do want to report the delimiter found anyway in case it's a lone '\r'.


-- 
To view, visit http://gerrit.cloudera.org:8080/2803
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id42b441674bb21517ad2788b99942a4b5dc55420
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message