impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-1878: Support INSERT and LOAD DATA on S3 and between filesystems
Date Fri, 29 Apr 2016 21:36:17 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-1878: Support INSERT and LOAD DATA on S3 and between filesystems
......................................................................


Patch Set 24:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/2574/24/be/src/util/hdfs-util-test.cc
File be/src/util/hdfs-util-test.cc:

Line 58:   EXPECT_TRUE(FilesystemsMatch("hdfs://namenode/temp_dir/temp_path", "hdfs://"));
> This case is special, because for some reason if we get a path with only a 
Should be two non-zero lengths, so still don't see why they compare true.


http://gerrit.cloudera.org:8080/#/c/2574/24/tests/metadata/test_ddl.py
File tests/metadata/test_ddl.py:

Line 70:   @SkipIfS3.qualified_path
> I'll read up on the semantics of PURGE and try to fix it for S3 or write an
okay. let's change this to SkipIfS3.jra(3459) or whatever the syntax is then, since it doesn't
seem related to the qualified_path jira.  Or if this test doesn't make sense on s3, let's
have hdfs_purge or something.

Also, might be worth seeing what DROP TABLE PURGE does on S3.


-- 
To view, visit http://gerrit.cloudera.org:8080/2574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I94e15ad67752dce21c9b7c1dced6e114905a942d
Gerrit-PatchSet: 24
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message