impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Kudu: Update DCHECK about plan nodes that don't use runtime filters
Date Fri, 29 Apr 2016 19:06:07 GMT
Matthew Jacobs has posted comments on this change.

Change subject: Kudu: Update DCHECK about plan nodes that don't use runtime filters
......................................................................


Patch Set 1:

(1 comment)

How did you discover this? It'd be good to add a test case.

http://gerrit.cloudera.org:8080/#/c/2900/1/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:

Line 520:         DCHECK(plan_node.__isset.hbase_scan_node || plan_node.__isset.kudu_scan_node)
I think this should also fail for external data source scan nodes, i.e. 'data_source_node'


-- 
To view, visit http://gerrit.cloudera.org:8080/2900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice6f7efaa701b60d0e5b75b8696d7a6e6ce96de6
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message