impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-1583: Simplify PartitionedHashJoinNode::ProcessProbeBatch()
Date Fri, 29 Apr 2016 01:17:31 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-1583: Simplify PartitionedHashJoinNode::ProcessProbeBatch()
......................................................................


Patch Set 2:

(4 comments)

Need to take another pass in more detail, but this makes the code much easier to read!

http://gerrit.cloudera.org:8080/#/c/2893/2/be/src/exec/partitioned-hash-join-node-ir.cc
File be/src/exec/partitioned-hash-join-node-ir.cc:

Line 151: !matched_probe_ && JoinOp != TJoinOp::LEFT_SEMI_JOIN)
reverse these so the constant one short circuits the non constant.


Line 278: patch
batch


Line 305: should_continue = 
rather than doing this indirect break, why not write it:

if (!ProcessProbeRowInnerJoin(..)) break;


Line 329: current_probe_row_ == NULL
what does this condition mean? the comment only explains the third one.


-- 
To view, visit http://gerrit.cloudera.org:8080/2893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2091bdf97ab34c5cdc84e84394c579a5b36afc0
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message