impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Ignore spurious MemPool DCHECK when using --disable_mem_pools flag
Date Fri, 29 Apr 2016 00:51:27 GMT
Dan Hecht has posted comments on this change.

Change subject: Ignore spurious MemPool DCHECK when using --disable_mem_pools flag
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2885/1/be/src/runtime/mem-pool.cc
File be/src/runtime/mem-pool.cc:

Line 123:     if (!FLAGS_disable_mem_pools) DCHECK_GE(next_chunk_size_, INITIAL_CHUNK_SIZE);
how about moving it to Line 130, which is where we want to depend on this invariant anyway.


-- 
To view, visit http://gerrit.cloudera.org:8080/2885
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7475202eb81ee7c73dc3fda9fb44b18108b620ee
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message