impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Casey Ching (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Preview: Refactor CREATE TABLE grammar rules in prep for PRIMARY KEY
Date Thu, 28 Apr 2016 23:24:59 GMT
Casey Ching has posted comments on this change.

Change subject: Preview: Refactor CREATE TABLE grammar rules in prep for PRIMARY KEY
......................................................................


Patch Set 3:

> > > Just curious, is this necessary for the CREATE TABLE for
 > internal
 > > > Kudu tables?
 > >
 > > No not really. It's just a massive pain to make sense of the
 > > existing rules. This should make future create table related
 > > language changes easier.
 > 
 > Gotcha. Would you be able to post the review for the CREATE TABLE
 > case handling internal tables before iterating on this? It'd be
 > good to get that stuff wrapped up and this looks like this one will
 > take a while. If they're conflicting, I do think we should get the
 > review to get the internal case handled sooner since that's on the
 > short term roadmap we discussed in the sync up.

Doing both the refactor and adding the primary key without the refactor would mean going through
the "massive pain" twice. It's probably best to avoid if possible.

-- 
To view, visit http://gerrit.cloudera.org:8080/2865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a2b9e380a0b90c0e2e6f10f6905cab5164cb3c4
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message