impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-1740: Add support for skip.header.line.count.
Date Thu, 28 Apr 2016 12:27:36 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-1740: Add support for skip.header.line.count.
......................................................................


Patch Set 24:

(3 comments)

Thanks for the review.

http://gerrit.cloudera.org:8080/#/c/2110/24/be/src/exec/hdfs-table-sink.h
File be/src/exec/hdfs-table-sink.h:

Line 237:   /// many empty lines at the beginning of new files, which will be skipped by the
> of new text files
Done


http://gerrit.cloudera.org:8080/#/c/2110/24/common/thrift/DataSinks.thrift
File common/thrift/DataSinks.thrift:

Line 58:   /// The 'skip.header.line.count' property of the target Hdfs table. We will insert
this
> precede w/ blank line
Done


Line 59:   /// many empty lines at the beginning of new files, which will be skipped by the
> of new text files
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/2110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I595f01a165d41499ca1956fe748ba3840a6eb543
Gerrit-PatchSet: 24
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message