impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Added support for building Impala Front End separately (and quickly)
Date Wed, 27 Apr 2016 17:42:53 GMT
Matthew Jacobs has posted comments on this change.

Change subject: Added support for building Impala Front End separately (and quickly)
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2875/6/bin/make_impala.sh
File bin/make_impala.sh:

Line 48: fe_only
Hm, now that I see this I think you were right that the duplication with buildall.sh is problematic.
It's weird that this is "fe_only" which implies it normally builds fe.

I think there are a few ways to go:
1) make_impala.sh would start building the fe by default, and then buildall.sh doesn't explicitly
build the fe like it does now.  Unless buildall.sh is called with fe_only, it would call this
to build both. Then this script would really be the script to build impala and buildall.sh
would be more like "set up the environment, testdata, etc.". However, that might be more work
because I think there are a few other dependencies that buildall.sh currently handles (e.g.
building ext-data-source).
2) Go back to how this was in #4.

I'd love to see us move in the direction of #1, but it's larger than what you set out for
:) If you want to get this in sooner, let's just go with the second (i.e. going back to how
this was in patch #4). Sorry for the back-and-forth here, thanks for your patience.

Tim, what do you think?


-- 
To view, visit http://gerrit.cloudera.org:8080/2875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I486bb95757334f9df77c4a97150b2b34c5c0e2c4
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Misha Dmitriev <misha@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Misha Dmitriev <misha@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message