impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3427: test_insert_wide_table: use unique_database fixture
Date Wed, 27 Apr 2016 14:26:16 GMT
Michael Brown has submitted this change and it was merged.

Change subject: IMPALA-3427: test_insert_wide_table: use unique_database fixture
......................................................................


IMPALA-3427: test_insert_wide_table: use unique_database fixture

test_insert_wide_table runs in parallel attempts to DROP/CREATE tables
with the same name into the same database. A race thus exists in which
one tests can stomp on each others' tables.

The fix is to use the unique_database fixture, in which each test can
run in parallel within its own database, and thus its own table.

Change-Id: If3b22f1b089d20c6024d6d680af82f102342394e
Reviewed-on: http://gerrit.cloudera.org:8080/2871
Reviewed-by: Sailesh Mukil <sailesh@cloudera.com>
Reviewed-by: Alex Behm <alex.behm@cloudera.com>
Tested-by: Michael Brown <mikeb@cloudera.com>
---
M tests/query_test/test_insert.py
1 file changed, 2 insertions(+), 4 deletions(-)

Approvals:
  Michael Brown: Verified
  Sailesh Mukil: Looks good to me, but someone else must approve
  Alex Behm: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/2871
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If3b22f1b089d20c6024d6d680af82f102342394e
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>

Mime
View raw message