impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Added support for building Impala Front End separately (and quickly)
Date Wed, 27 Apr 2016 00:09:00 GMT
Tim Armstrong has posted comments on this change.

Change subject: Added support for building Impala Front End separately (and quickly)
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2875/2/bin/make_impala.sh
File bin/make_impala.sh:

Line 138: if [ $BUILD_TESTS -eq 1 ]
> I initially wanted to implement it that way. But then I realized that if so
Ah right, I see your point. Personally I'd prefer to keep it more consistent now and then
deal with that use case if we need it in the future. But I'm not opposed to keeping it this
way if others think that's better.

Matt?


-- 
To view, visit http://gerrit.cloudera.org:8080/2875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I486bb95757334f9df77c4a97150b2b34c5c0e2c4
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Misha Dmitriev <misha@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Misha Dmitriev <misha@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message