impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Added support for building Impala Front End separately (and quickly)
Date Tue, 26 Apr 2016 23:26:57 GMT
Matthew Jacobs has posted comments on this change.

Change subject: Added support for building Impala Front End separately (and quickly)
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/2875/2/buildall.sh
File buildall.sh:

Line 291: MAKE_IMPALA_ARGS="${MAKE_IMPALA_ARGS} -build_type=${CMAKE_BUILD_TYPE}"
        : 
        : if [ $BUILD_FE_ONLY -eq 1 ]; then
        :   echo "Build frontend only"
        :   $IMPALA_HOME/bin/make_impala.sh ${MAKE_IMPALA_ARGS} -cmake_only
        :   make fe
        :   exit 0
        : fi
There's a lot that can happen before this, which seems to contradict that this is "fe only".
Can you move this up higher and avoid doing things like loading the metastore snapshot, killing
the minicluster, etc.?


http://gerrit.cloudera.org:8080/#/c/2875/2/fe/CMakeLists.txt
File fe/CMakeLists.txt:

Line 1: add_custom_target(fe DEPENDS thrift-deps function-registry
Please add a copyright header


-- 
To view, visit http://gerrit.cloudera.org:8080/2875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I486bb95757334f9df77c4a97150b2b34c5c0e2c4
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Misha Dmitriev <misha@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message