impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2686: Add breakpad crash handler to all daemons
Date Tue, 26 Apr 2016 22:38:08 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-2686: Add breakpad crash handler to all daemons
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2028/6/be/src/util/minidump.cc
File be/src/util/minidump.cc:

Line 79:       // To prevent us from messing with a file that is currently being written we
only
> The cases I had in mind at the time were multiple daemons writing to the sa
Sounds good to me.


-- 
To view, visit http://gerrit.cloudera.org:8080/2028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a37a38488716ffe34296f3490ae291bbb7228d6
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Silvius Rus <srus@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message