impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation
Date Tue, 26 Apr 2016 17:47:48 GMT
Tim Armstrong has posted comments on this change.

Change subject: Kudu: Exclude non-Kudu symbols during stub client generation
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/2864/1/bin/bootstrap_toolchain.py
File bin/bootstrap_toolchain.py:

Line 127: def build_kudu_stub(toolchain_root, kudu_version, compiler):
Can we move this logic to a different file? Or at least to the bottom of this file. It's really
confusing to read this file when there is a big block of Kudu-specific logic in the middle
of the regular bootstrap logic.


Line 186:       if sym_type.upper() not in "TW":
Was stubbing weak symbols necessary to get impala to think? This is all very confusing and
I can't really reason about what is and isn't necessary.


-- 
To view, visit http://gerrit.cloudera.org:8080/2864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54292095692ce38c255a8df48cf8f3f655d797b0
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message