impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2548: Codegen Tuple::MaterializeExprs() and use in TopN node
Date Mon, 25 Apr 2016 22:45:01 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-2548: Codegen Tuple::MaterializeExprs() and use in TopN node
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/1901/10/be/src/exec/topn-node.cc
File be/src/exec/topn-node.cc:

Line 79:       sort_exec_exprs_.sort_tuple_slot_expr_ctxs(), NULL, &materialize_exprs_no_pool_fn));
> Since CodegenMaterializeExprs() uses the IRBuilder, it either bakes in 'poo
i guess we can do this for now, but as you pointed out, it makes everything very complicated.

in the medium, we want to get away from irbuilder and only rely on cross-compiled code, at
which point the runtime optimization should take care of cases like these.

could you outline the reasoning behind this code structure somewhere, so it's not as mystifying?


-- 
To view, visit http://gerrit.cloudera.org:8080/1901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib422a8d50303c21c6a228675157bf867e8619444
Gerrit-PatchSet: 10
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message