impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3306: Add command-line flags to set S3 access configurations
Date Mon, 25 Apr 2016 21:07:49 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-3306: Add command-line flags to set S3 access configurations
......................................................................


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/2850/3/be/src/common/init.cc
File be/src/common/init.cc:

Line 210:   EXIT_IF_ERROR(impala::HdfsFsCache::Init());
Note this should be changed once Tim's patch goes in.


http://gerrit.cloudera.org:8080/#/c/2850/3/be/src/runtime/hdfs-fs-cache.h
File be/src/runtime/hdfs-fs-cache.h:

Line 68:   /// If blank, the default value is taken from the local Hadoop client configuration.
in these comments, maybe say that both must be set?


http://gerrit.cloudera.org:8080/#/c/2850/3/be/src/util/os-util.cc
File be/src/util/os-util.cc:

Line 112: do_trim
are there cases when it's not safe to do this?


http://gerrit.cloudera.org:8080/#/c/2850/3/tests/custom_cluster/test_s3a_access.py
File tests/custom_cluster/test_s3a_access.py:

Line 66:     in a custom cluster test.'''
what's needed to do this? let's at least file a JIRA since not having any positive tests for
this code isn't something we should live with for long.


-- 
To view, visit http://gerrit.cloudera.org:8080/2850
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ba103bcb399861683066fd00219d30c180db043
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message