impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3306: Add command-line flags to set S3 access configurations
Date Mon, 25 Apr 2016 17:55:14 GMT
Hello Henry Robinson,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/2850

to look at the new patch set (#3).

Change subject: IMPALA-3306: Add command-line flags to set S3 access configurations
......................................................................

IMPALA-3306: Add command-line flags to set S3 access configurations

This patch adds two flags, namely 's3a_access_key_cmd' and
's3a_secret_key_cmd' each of which should be a Unix command that
would retrieve the S3 access key and the S3 secret key respectively.
These keys are used when creating a connection to S3 so that Impala
is given access.

This patch gives users the safer option of not needing to put the
access and secret keys in the world readable core-site.xml file.

Change-Id: I2ba103bcb399861683066fd00219d30c180db043
---
M be/src/common/init.cc
M be/src/rpc/thrift-server.cc
M be/src/runtime/hdfs-fs-cache.cc
M be/src/runtime/hdfs-fs-cache.h
M be/src/util/os-util.cc
M be/src/util/os-util.h
M be/src/util/webserver.cc
M tests/common/skip.py
A tests/custom_cluster/test_s3a_access.py
9 files changed, 122 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/50/2850/3
-- 
To view, visit http://gerrit.cloudera.org:8080/2850
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2ba103bcb399861683066fd00219d30c180db043
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>

Mime
View raw message