impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2660: Respect auth_to_local configs from hdfs configs
Date Mon, 25 Apr 2016 10:38:57 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-2660: Respect auth_to_local configs from hdfs configs
......................................................................


Patch Set 4:

>This patch should also add code to do the mapping in TSasl::getUsername() (see use of
FLAGS_force_lowercase_username there), otherwise users will be confused about why the mapping
only takes effect for authorization, not for authentication.

I'm not sure I understand this. The current patch affects only authorization, basically *after*
authentication.  Do you mean we should undo the changes added for FLAGS_force_lowercase_username
patch and instead do it via auth_to_local rules as a part of this patch ?

-- 
To view, visit http://gerrit.cloudera.org:8080/2800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76485b83c14ba26f6fce66e5f83e8014667829e0
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Juan Yu <jyu@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message