impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wes McKinney (Code Review)" <ger...@cloudera.org>
Subject [hs2client-CR] Initial structure for the C++ hiveserver2 client.
Date Sat, 23 Apr 2016 14:42:56 GMT
Wes McKinney has posted comments on this change.

Change subject: Initial structure for the C++ hiveserver2 client.
......................................................................


Patch Set 8:

(7 comments)

Brief comments on the Column types and a couple other things. Getting close, looking forward
to putting together the Python wrapper

http://gerrit.cloudera.org:8080/#/c/2645/8/src/hs2client/columnar-row-set.h
File src/hs2client/columnar-row-set.h:

Line 61: Column
> Please add a good comment here explaining how this is used, including the d
A pattern I've used in the past is a base class and a subclass that is templated for the typed
columns. So that you can have a Column* and later cast it to TypedColumn<T>*. That may
end up being too much complexity here, though.


http://gerrit.cloudera.org:8080/#/c/2645/8/src/hs2client/hs2session.cc
File src/hs2client/hs2session.cc:

Line 101:   Status Open(hs2::TSessionHandle session_handle, const std::string& shema_pattern)
{
Typo: schema_pattern


Line 123:   return op->Open(impl_->handle, shema_pattern);
Typos


Line 134:     req.__set_schemaName(shema_pattern);
shema -> schema


Line 154:   return op->Open(impl_->handle, shema_pattern, table_pattern);
shema -> schema


Line 165:     req.__set_schemaName(shema_pattern);
shema -> schema


http://gerrit.cloudera.org:8080/#/c/2645/8/src/hs2client/hs2session.h
File src/hs2client/hs2session.h:

Line 49:   // and table_pattern may contain wildcards.
Can you give an example of what a wild card looks like (e.g. "foo_*" matches all schemas starting
with "foo_"), or otherwise give the user some guidance (e.g. link to documentation)?


-- 
To view, visit http://gerrit.cloudera.org:8080/2645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7be82d5897ad6093116915b17924674c4ae508a0
Gerrit-PatchSet: 8
Gerrit-Project: hs2client
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Wes McKinney <wes@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message