impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Casey Ching (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Kudu: Remove TODO about a better errror message for invalid table params
Date Fri, 22 Apr 2016 23:34:08 GMT
Casey Ching has posted comments on this change.

Change subject: Kudu: Remove TODO about a better errror message for invalid table params
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2842/1/fe/src/main/java/com/cloudera/impala/catalog/KuduTable.java
File fe/src/main/java/com/cloudera/impala/catalog/KuduTable.java:

Line 223
> this is easy to fix. you simply need to point out which parameter exactly i
Sure, but this TODO is about tweaking something that shouldn't even be done. Why not put the
effort into not doing this thing in the first place?


-- 
To view, visit http://gerrit.cloudera.org:8080/2842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I501f5b4284e292bac82c9200a26faeb07e732f07
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message