impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Huaisi Xu (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3385: Fix crashes on accessing error_log
Date Fri, 22 Apr 2016 23:34:00 GMT
Huaisi Xu has uploaded a new patch set (#7).

Change subject: IMPALA-3385: Fix crashes on accessing error_log
......................................................................

IMPALA-3385: Fix crashes on accessing error_log

We used to check error_log empty with error_log.empty(), but
this may return false even when some of its member has empty
messages, thus crashes impala.

This commit:

1. Make sure that messages vectors are always
non-empty when accessed.

2. Remove error_log from hdfsScanNode::splitprocess since the
logs may contain irrelevant errors. This also prevents a
potential race condition when error_log is checked and enters
if clause, but later is changed by other threads.

3. Hold locks when returning error_log.

Change-Id: I3a7e3d22e26147ada780aae5aed1f2e25a515afc
---
M be/src/exec/hdfs-scan-node.cc
M be/src/runtime/coordinator.cc
M be/src/runtime/runtime-state.cc
M be/src/runtime/runtime-state.h
M be/src/util/error-util.cc
M common/thrift/ImpalaInternalService.thrift
6 files changed, 28 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/29/2829/7
-- 
To view, visit http://gerrit.cloudera.org:8080/2829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3a7e3d22e26147ada780aae5aed1f2e25a515afc
Gerrit-PatchSet: 7
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>

Mime
View raw message