impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Casey Ching (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Kudu: Remove TODO about checking for unsupported types in table loading
Date Fri, 22 Apr 2016 23:30:36 GMT
Casey Ching has posted comments on this change.

Change subject: Kudu: Remove TODO about checking for unsupported types in table loading
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2834/1/fe/src/main/java/com/cloudera/impala/catalog/KuduTable.java
File fe/src/main/java/com/cloudera/impala/catalog/KuduTable.java:

Line 154
> please check with david what the exact purpose was, i don't recall. but let
I think this line was added by Martin. The comments in the merge review are

Henry Robinson
what happens if this TODO isn't done?


David Ribeiro Alves
not sure what this TODO means in general, particularly in this place. It seems that key type
checking should either be done in a single place or relegated to Kudu. I've marked this as
a follow up item to add a test for.


Marcel Kornacker
marked where

David Ribeiro Alves
created IMPALA-3157


-- 
To view, visit http://gerrit.cloudera.org:8080/2834
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I681d80776f28904a6171cac5aebde3a02327b295
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message