impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2736: Basic column-wise slot materialization in Parquet scanner.
Date Fri, 22 Apr 2016 23:29:05 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-2736: Basic column-wise slot materialization in Parquet scanner.
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/2779/5/be/src/exec/hdfs-parquet-scanner.cc
File be/src/exec/hdfs-parquet-scanner.cc:

Line 367:   bool ReadValueBatch(MemPool* pool, int max_values, int tuple_size,
> Ah I see, sorry, I didn't trace through all the virtual + overloaded non-vi
Yea, that would be confusing because we special case booleans. We would need yet another implementation
of ReadValueBatch() in BoolColumnReader. We already have some code duplication, and I'd prefer
to keep it to a minimum.

I considered ditching the BoolBolumnReader altogether but I don't think it's easy because
it has custom decoding logic.


http://gerrit.cloudera.org:8080/#/c/2779/5/be/src/util/rle-encoding.h
File be/src/util/rle-encoding.h:

Line 250:   if (repeat_count_ == 0) {
> Compared against "repeat_count_ + literal_count_ == 0" and the current chan
Thanks, Mostafa! Let's leave it as is then, even if it is "magical"


-- 
To view, visit http://gerrit.cloudera.org:8080/2779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72a613fa805c542e39df20588fb25c57b5f139aa
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message