impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2198: Differentiate queries in exceptional states in web UI
Date Fri, 22 Apr 2016 22:19:30 GMT
Thomas Tauber-Marshall has posted comments on this change.

Change subject: IMPALA-2198: Differentiate queries in exceptional states in web UI
......................................................................


Patch Set 6:

(2 comments)

I looked and couldn't find any already existing test for the webui.

I'm not sure how to go about testing the layout of the html, but at the very least it shouldn't
be too bad to check that the json endpoints are exposing the right thing.

http://gerrit.cloudera.org:8080/#/c/2625/6/be/src/service/impala-server-callbacks.cc
File be/src/service/impala-server-callbacks.cc:

Line 280:   bool waiting = record.query_state == beeswax::QueryState::EXCEPTION ||
> since 'waiting' can be ambiguous, how about a quick comment, e.g.:
Done


http://gerrit.cloudera.org:8080/#/c/2625/6/be/src/service/impala-server.h
File be/src/service/impala-server.h:

Line 612:     int64_t last_active_time;
> add a comment indicating what this is and what clock it's based on
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/2625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I47d0b642ecb573fefbbf337b8c8f2c479b0d49b2
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message