impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Huaisi Xu (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3385: Fix crashes on accessing error_log
Date Fri, 22 Apr 2016 21:39:45 GMT
Huaisi Xu has posted comments on this change.

Change subject: IMPALA-3385: Fix crashes on accessing error_log
......................................................................


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/2829/5/be/src/util/error-util.cc
File be/src/util/error-util.cc:

Line 135:     if (v.second.count == 0) continue;
> this isn't fixed in your new patchset
I did in AppendError(), I +1 for count for any kind of error. so this count is always synced.


Line 159:     if (v.second.count == 0) continue;
> This wasn't fixed in your new patchest.  did you upload the correct patch?
see above.


Line 193:       errors.find(TErrorCode::GENERAL)->second.messages.size() - 1 : 0;
> This didn't change in your new patchset even though you say "Done".
see above. I changed how the count is calculated.


-- 
To view, visit http://gerrit.cloudera.org:8080/2829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a7e3d22e26147ada780aae5aed1f2e25a515afc
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message