impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3306: Add command-line flags to set S3 access configurations
Date Fri, 22 Apr 2016 21:08:40 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-3306: Add command-line flags to set S3 access configurations
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2850/1/be/src/runtime/hdfs-fs-cache.cc
File be/src/runtime/hdfs-fs-cache.cc:

Line 50: void HdfsFsCache::Init(
> Currently, I've made it so that Init() doesn't disallow Impala from startin
As discussed, it's ok if the keys are wrong (unless there's a really easy way to test them
here), but it would be worthwhile to fail if the scripts return an error.


-- 
To view, visit http://gerrit.cloudera.org:8080/2850
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ba103bcb399861683066fd00219d30c180db043
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message