impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3329: custom cluster tests: set -max_log_files to unlimited
Date Fri, 22 Apr 2016 16:48:32 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-3329: custom cluster tests: set -max_log_files to unlimited
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2759/3/bin/run-all-tests.sh
File bin/run-all-tests.sh:

Line 176:     rm -rf ${IMPALA_CUSTOM_CLUSTER_TEST_LOGS_DIR}
> I forgot about that. Let me think on that a bit.
Alex, my take on this is the original spirit of "repeated runs" is to run tests repeatedly
without restarting impalad. While apparently some flaky tests prevent this from happening
now, it's something we should work toward.

The nature of the custom cluster tests' always restarting impalad collides with the spirit
of repeated runs.

My take would be only to run the custom cluster tests once, or maybe not even at all, in the
repeated runs job. If we need to run custom cluster tests multiple times, that's probably
a different plan, or in a different phase of the repeated runs job.


-- 
To view, visit http://gerrit.cloudera.org:8080/2759
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefbb2a8616adcb0cd2fb838505117e0e9ba39083
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message