impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Skye Wanderman-Milne (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3378/IMPALA-3379: fix various JNI issues
Date Thu, 21 Apr 2016 18:36:35 GMT
Skye Wanderman-Milne has posted comments on this change.

Change subject: IMPALA-3378/IMPALA-3379: fix various JNI issues
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2820/4/be/src/exprs/hive-udf-call.cc
File be/src/exprs/hive-udf-call.cc:

Line 203: if (env == NULL) return Status("Failed to get/create JVM");
> We will always call Close() even if Open() failed, right ?
We should: https://github.com/cloudera/Impala/blob/cdh5-trunk/be/src/exprs/expr-context.cc#L43


-- 
To view, visit http://gerrit.cloudera.org:8080/2820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8cd089e355d2ee2d5ace81f05b214272c05cf941
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message