impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Toolchain-CR] Build Kudu from source
Date Thu, 21 Apr 2016 16:33:59 GMT
Tim Armstrong has posted comments on this change.

Change subject: Build Kudu from source
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2679/7/source/kudu/build.sh
File source/kudu/build.sh:

Line 97: # The line below configures clang to fing gcc from the toolchain. Without this the
       :     # build will still work on some system but there will be strange crashes at runtime.
       :     # On other systems, such as default RHEL6, the build will fail because c++11
isn't
       :     # supported on the system gcc.
       :     sed -i -r "s:^(set\(IR_FLAGS):\1\n  --gcc-toolchain=$(dirname $(which $CXX))/..:"
\
       :         src/kudu/codegen/CMakeLists.txt
> No. I think the workaround Casey is using is reasonable for the time being.
Just passing by. #3 may not be feasible, since we depend on the toolchain being relocatable
by copying and I don't think the Clang build process can necessarily handle relative paths
to the gcc toolchain.

Wes was trying to fix this in native-toolchain already but wasn't able to make it work (he
ended up using --gcc-toolchain).

https://github.com/cloudera/native-toolchain/pull/16


-- 
To view, visit http://gerrit.cloudera.org:8080/2679
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ec8494fb4e765ec796b31212c811af34e8514bd
Gerrit-PatchSet: 7
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Adar Dembo <adar@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message