impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Casey Ching (Code Review)" <>
Subject [Toolchain-CR] Build Kudu from source
Date Thu, 21 Apr 2016 07:51:06 GMT
Casey Ching has posted comments on this change.

Change subject: Build Kudu from source

Patch Set 7:


Did you want Tim to look at this too?
Commit Message:

Line 15: One downside is there is no longer a clear path to building a stubbed
       : client on an unsupported OS. Building the stub is a two step process,
       : that first requires a real client to be built. Since step one cannot be
       : done on an unsupported OS, the build would need to use artifacts built
       : on another OS. The expected solution is that users who need the stubs
       : will build the stubs themselves.
> outdated now
I'm not sure what you mean. This is really what happened. The "user who needs the stubs" is
the Impala build and it builds the stubs itself.
File source/kudu/

Line 82: if needs_build_package ; then
> can we reverse this and exit early? save some indenting as this is a huge b

Line 97: fing
> find

Line 98: system
> systems

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ec8494fb4e765ec796b31212c811af34e8514bd
Gerrit-PatchSet: 7
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Casey Ching <>
Gerrit-Reviewer: Adar Dembo <>
Gerrit-Reviewer: Casey Ching <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-HasComments: Yes

View raw message