impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Remove dead RuntimeState code
Date Thu, 21 Apr 2016 05:11:46 GMT
Tim Armstrong has posted comments on this change.

Change subject: Remove dead RuntimeState code
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

I think there is some additional opportunity to remove dead code.

http://gerrit.cloudera.org:8080/#/c/2830/1/be/src/exec/hbase-scan-node.cc
File be/src/exec/hbase-scan-node.cc:

Line 240: 
I think the value of num_errors_ is unused after this change.


http://gerrit.cloudera.org:8080/#/c/2830/1/be/src/exec/hdfs-scanner.cc
File be/src/exec/hdfs-scanner.cc:

Line 605: 
I think this variable is unused too.


-- 
To view, visit http://gerrit.cloudera.org:8080/2830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8fb59935906c1183b771f5d7991693fa8ff3c95e
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message