impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3385: hold locks when returning error_log
Date Thu, 21 Apr 2016 02:35:32 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-3385: hold locks when returning error_log
......................................................................


Patch Set 1:

> Yes I will try tomorrow. Dan could you say a little about why you
 > do not think so?

the hdfs scan node path that crashes doesn't use this accessor. I think the error log logic
is probably broken in multiple ways and we don't understand all the ways it's broken.  We
need to repro in order to be confident we're fixing, and to regression test.

To repro, you could try adding a stress option that injects synthetic errors into queries.

-- 
To view, visit http://gerrit.cloudera.org:8080/2829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a7e3d22e26147ada780aae5aed1f2e25a515afc
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message