impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Huaisi Xu (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3385: hold locks when returning error_log
Date Thu, 21 Apr 2016 01:54:30 GMT
Huaisi Xu has posted comments on this change.

Change subject: IMPALA-3385: hold locks when returning error_log
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2829/1/be/src/runtime/runtime-state.cc
File be/src/runtime/runtime-state.cc:

Line 196: error_log
> Shouldn't you update all the direct references of error_log_ to use error_l
I think if that in the same class I do not have to, right? 

There are runtime states kept by coordinator, which is not related to this one... I am not
sure whether you are referring to those.


-- 
To view, visit http://gerrit.cloudera.org:8080/2829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a7e3d22e26147ada780aae5aed1f2e25a515afc
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message