impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3354: bad sorter pivot selection on some inputs
Date Thu, 21 Apr 2016 01:34:37 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-3354: bad sorter pivot selection on some inputs
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2824/2/be/src/runtime/sorter.cc
File be/src/runtime/sorter.cc:

Line 242:     TupleIterator(TupleSorter* parent, int64_t index)
could you add a function comment for the constructor?  i.e. what inputs are and what it computes.


-- 
To view, visit http://gerrit.cloudera.org:8080/2824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae50112b6deca3d6268e18b6f4daae1af279b452
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message