impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Source query files from shell.
Date Wed, 20 Apr 2016 21:49:09 GMT
Henry Robinson has posted comments on this change.

Change subject: Source query files from shell.
......................................................................


Patch Set 1:

(2 comments)

Thanks for the review!

http://gerrit.cloudera.org:8080/#/c/2663/1/shell/impala_shell.py
File shell/impala_shell.py:

Line 1034:       print_to_stderr("Error opening file '%s': %s" % (args, e))
> Reducing the scope of this try/except to just the open() call would be nice
Done


Line 1110:     if not self.imp_client.connected: return False
> Will the user see a message saying why the file wasn't executed?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/2663
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib05df3e755cd12e9e9562de6b353857940eace03
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message