impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-1850: Allow fs.defaultFS to be set to a non-HDFS filesystem
Date Wed, 20 Apr 2016 19:04:23 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-1850: Allow fs.defaultFS to be set to a non-HDFS filesystem
......................................................................


Patch Set 19:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/1121/19/testdata/bin/generate-schema-statements.py
File testdata/bin/generate-schema-statements.py:

Line 198:  tblproperties["avro.schema.url"] = "%s/%s/%s/{table_name}.json" \
        :       % (DEFAULT_FS
> I am not sure about this. How do I check this?
Seems like load-data.py calls this. I suggest overriding DEFAULT_FS if --hdfs_namenode is
set, to preserve existing behaviour, and adding a 
  
  # TODO Is this flag ever used?


-- 
To view, visit http://gerrit.cloudera.org:8080/1121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f45bef6c94ece634045acb906d12591587ccfed
Gerrit-PatchSet: 19
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: anujphadke <aphadke@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Juan Yu <jyu@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: anujphadke <aphadke@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message