impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Skye Wanderman-Milne (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3378/IMPALA-3379: fix various JNI issues
Date Wed, 20 Apr 2016 15:42:16 GMT
Skye Wanderman-Milne has posted comments on this change.

Change subject: IMPALA-3378/IMPALA-3379: fix various JNI issues
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2820/2/be/src/exec/external-data-source-executor.cc
File be/src/exec/external-data-source-executor.cc:

Line 61: jclass cl = env->FindClass(
       :         "com/cloudera/impala/extdatasource/ExternalDataSourceExecutor");
       :     RETURN_ERROR_IF_EXC(env);
       :     RETURN_IF_ERROR(JniUtil::LocalToGlobalRef(env, cl, &executor_class_));
> I think we can use JniUtil::GetGlobalClassRef() here to make it look cleane
I agree, will change it.


-- 
To view, visit http://gerrit.cloudera.org:8080/2820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8cd089e355d2ee2d5ace81f05b214272c05cf941
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message