impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taras Bobrovytsky (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3155: Disable implicit casting of CHAR to STRING in CASE statements
Date Wed, 20 Apr 2016 07:16:30 GMT
Hello Internal Jenkins, Alex Behm,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/2762

to look at the new patch set (#5).

Change subject: IMPALA-3155: Disable implicit casting of CHAR to STRING in CASE statements
......................................................................

IMPALA-3155: Disable implicit casting of CHAR to STRING in CASE statements

All CHAR children of a CASE expression were automaticallally implicitly
cast to STRING. This commit removes this behavior for the THEN clause of
a CASE statement, i.e., if all THEN exprs of a CASE expression are CHAR,
then the type of the CASE expression will be CHAR.

Change-Id: I4aebac6849898693570bc3164fff40786c215358
---
M be/src/exprs/expr-test.cc
M fe/src/main/java/com/cloudera/impala/analysis/CaseExpr.java
M fe/src/main/java/com/cloudera/impala/analysis/Expr.java
M fe/src/test/java/com/cloudera/impala/analysis/AnalyzeExprsTest.java
4 files changed, 22 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/62/2762/5
-- 
To view, visit http://gerrit.cloudera.org:8080/2762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4aebac6849898693570bc3164fff40786c215358
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>

Mime
View raw message