impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <>
Subject [Toolchain-CR] Add support for Debug and Release+Asserts builds for LLVM 3.7+
Date Wed, 20 Apr 2016 06:34:50 GMT
Tim Armstrong has submitted this change and it was merged.

Change subject: Add support for Debug and Release+Asserts builds for LLVM 3.7+

Add support for Debug and Release+Asserts builds for LLVM 3.7+

There was a silent error occurring with applying LLVM patches
previously when the source version didn't match the package version.
We should report the error if the expected number of patches were
not found. As part of the change, get rid of LPACKAGE global variables
to give build scripts better control over patch directories. Previously
as a convenience, the lower-case package name and version was stored in
LPACKAGE and LPACKAGE_VERSION. Instead of this, this patch passes around
the lower-case name by default.

Also refactor archive extraction into an extract_archive() function that
will always use the correct portable extraction method, e.g. untar_xz().
This fixes a bug where we couldn't extract .xz archives pass directly to
header() on Centos 4.

These builds aren't added to the toolchain yet since we don't plan to
use these builds for llvm 3.7 or unpatched llvm 3.8.

Change-Id: Ic7f3430a56428e95e35279838e7b28909d12d10e
M source/avro/
M source/binutils/
M source/boost/
M source/breakpad/
M source/bzip2/
M source/cmake/
M source/cyrus-sasl/
M source/gcc/
M source/gdb/
M source/gflags/
M source/glog/
M source/googletest/
M source/gperftools/
M source/gtest/
M source/kudu/
M source/libevent/
M source/libunwind/
M source/llvm/
M source/llvm/
M source/llvm/
M source/llvm/
M source/lz4/
M source/openldap/
M source/openssl/
M source/python/
M source/rapidjson/
M source/re2/
M source/snappy/
M source/thrift/
M source/zlib/
31 files changed, 175 insertions(+), 124 deletions(-)

  Tim Armstrong: Looks good to me, approved; Verified

To view, visit
To unsubscribe, visit

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7f3430a56428e95e35279838e7b28909d12d10e
Gerrit-PatchSet: 2
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <>
Gerrit-Reviewer: Casey Ching <>
Gerrit-Reviewer: Tim Armstrong <>

View raw message