impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <>
Subject [Impala-CR](cdh5-trunk) IMPALA-3317: fix crash in sorter when spilling zero-length strings
Date Wed, 20 Apr 2016 00:17:49 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3317: fix crash in sorter when spilling zero-length strings

Patch Set 1:

File be/src/runtime/

Line 477:         } else {
> how about: DCHECK_EQ(var_len_blocks_.back(), cur_var_len_block) to support 

Line 564:           cur_sorted_var_len_block->Allocate<uint8_t>(total_var_len);
> same dcheck

Line 732:         // offset in the lower 32 bits.
> Add: see CopyVarLenDataConvertOffset()
Done. I'm going to refactor some of this in a follow-up patch so that the encode/decode methods
are adjacent to each other.

Line 827: block_size_
> Let's also dcheck that the calculation to get block_offset fits in 32-bits 
File testdata/workloads/functional-query/queries/QueryTest/large-sorts.test:

Line 3: set mem_limit=512m;
> Can you please keep these set statements together with the query ? The quer
I was seeing some weird behaviour. There is actually a bug in the regex that implements the
reset that I fixed. For some reason num_nodes doesn't seem to be taking effect when this test
file is executed (maybe because exec_single_node_rows_threshold was set) so I changed it to
set it in the test vector.
File tests/query_test/

Line 86
> why is this deleted?

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f64593e94d367d6b6efb61a8b86e35516f18839
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message