impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Kudu: Remove post merge TODOs that need no real work
Date Tue, 19 Apr 2016 22:45:05 GMT
Marcel Kornacker has posted comments on this change.

Change subject: Kudu: Remove post merge TODOs that need no real work
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2807/3/fe/src/main/java/com/cloudera/impala/catalog/delegates/UnsupportedOpDelegate.java
File fe/src/main/java/com/cloudera/impala/catalog/delegates/UnsupportedOpDelegate.java:

Line 24
i don't agree with removing this todo, please reinstate it. i was asking whether instead of
silently ignoring unsupported functionality this should return errors. 

as i see it, either the function bodies in this class all throw, or you allow errors to be
returned.


-- 
To view, visit http://gerrit.cloudera.org:8080/2807
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42c8120574def06727b645941bbf64cc69804120
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message