impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [hs2client-CR] Initial structure for the C++ hiveserver2 client.
Date Tue, 19 Apr 2016 21:53:56 GMT
Matthew Jacobs has posted comments on this change.

Change subject: Initial structure for the C++ hiveserver2 client.
......................................................................


Patch Set 6:

(6 comments)

Last few comments from the few files I didn't get to review yesterday.

http://gerrit.cloudera.org:8080/#/c/2645/6/src/hs2client/status.h
File src/hs2client/status.h:

Line 22: StatusCode
can you add a comment this is referencing the HS2 status codes, and brief comments inline
for the codes?


Line 23: Status
we don't need to append Status on each one.


http://gerrit.cloudera.org:8080/#/c/2645/6/src/hs2client/thrift-internal.cc
File src/hs2client/thrift-internal.cc:

Line 93: case
can you define a stringstream only where you need it, i.e. here and on l108? a bit easier
to follow given it's not used in most of the cases (and avoids allocating a stringstream).


Line 95: if (i != 0) {
       :           ss << ",";
       :         }
1 line


http://gerrit.cloudera.org:8080/#/c/2645/6/src/hs2client/thrift-internal.h
File src/hs2client/thrift-internal.h:

Line 68:   h
nit extra space


Line 74:  
extra space


-- 
To view, visit http://gerrit.cloudera.org:8080/2645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7be82d5897ad6093116915b17924674c4ae508a0
Gerrit-PatchSet: 6
Gerrit-Project: hs2client
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Wes McKinney <wes@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message