impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-1920: Fix userinfo and authority parsing.
Date Tue, 19 Apr 2016 10:35:22 GMT
Hello Internal Jenkins, Dan Hecht,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/2777

to look at the new patch set (#5).

Change subject: IMPALA-1920: Fix userinfo and authority parsing.
......................................................................

IMPALA-1920: Fix userinfo and authority parsing.

IMPALA-1170 fixed parsing of host parts in urls under the presence of
multiple '@' characters. However the parser contained another issue
where userinfo was erroneously extracted if the query part contained
an '@' but no userinfo was present. This change makes the parser only
extract userinfo before the first '/'.

This change also fixes an issue where the authority part was not
correctly parsed in absence of a terminating slash.

Change-Id: I6486aecc7344f40d6f85d70960866fbb45bea2e1
---
M be/src/exprs/expr-test.cc
M be/src/util/url-parser.cc
2 files changed, 34 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/77/2777/5
-- 
To view, visit http://gerrit.cloudera.org:8080/2777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6486aecc7344f40d6f85d70960866fbb45bea2e1
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>

Mime
View raw message