impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Internal Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Kudu: Remove post merge TODOs that need no real work
Date Tue, 19 Apr 2016 04:27:54 GMT
Internal Jenkins has submitted this change and it was merged.

Change subject: Kudu: Remove post merge TODOs that need no real work
......................................................................


Kudu: Remove post merge TODOs that need no real work

Comments on files:

1) BinaryPredicate: The TODO was to create a more generic function but I
   couldn't find another place that needed something like this.
2) KuduTable: Addressed TOOD by adding comment to explain constant "-1".
3) UnsupportedOpDelegate: The TODO was to consider returning an error, I
   didn't see much benefit in doing that.
4) KuduScanNode: The TODO was to consider replacing a predicate with a
   literal "false", that's a fine suggestion but not particularly
   related to Kudu. It's just a general planner enhancement so I won't
   address that.

Change-Id: I42c8120574def06727b645941bbf64cc69804120
Reviewed-on: http://gerrit.cloudera.org:8080/2807
Reviewed-by: Alex Behm <alex.behm@cloudera.com>
Tested-by: Internal Jenkins
---
M fe/src/main/java/com/cloudera/impala/analysis/BinaryPredicate.java
M fe/src/main/java/com/cloudera/impala/catalog/KuduTable.java
M fe/src/main/java/com/cloudera/impala/catalog/delegates/UnsupportedOpDelegate.java
M fe/src/main/java/com/cloudera/impala/planner/KuduScanNode.java
4 files changed, 1 insertion(+), 9 deletions(-)

Approvals:
  Internal Jenkins: Verified
  Alex Behm: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/2807
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I42c8120574def06727b645941bbf64cc69804120
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Internal Jenkins

Mime
View raw message