impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taras Bobrovytsky (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3155: Disable implicit casting of CHAR to STRING in CASE statements
Date Tue, 19 Apr 2016 04:10:34 GMT
Taras Bobrovytsky has posted comments on this change.

Change subject: IMPALA-3155: Disable implicit casting of CHAR to STRING in CASE statements
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/2762/1/fe/src/main/java/com/cloudera/impala/analysis/CaseExpr.java
File fe/src/main/java/com/cloudera/impala/analysis/CaseExpr.java:

Line 247:       if (children_.get(0).getType().isScalarType(PrimitiveType.CHAR)) {
> Looks like the confusing part was in line 249. That analyze() is redundant 
Done. Created a helper function.


http://gerrit.cloudera.org:8080/#/c/2762/1/testdata/workloads/functional-query/queries/QueryTest/exprs.test
File testdata/workloads/functional-query/queries/QueryTest/exprs.test:

Line 2420: select case when 5 < 3 then cast('L'  as char(1))  else cast('M'  as char(1))
end
> A more appropriate place for such a test is AnalyzeExprs.TestCaseExpr() bec
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/2762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4aebac6849898693570bc3164fff40786c215358
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message