impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Casey Ching (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Kudu merge: Consolidate checkTypeCompatibility()
Date Tue, 19 Apr 2016 00:19:21 GMT
Casey Ching has posted comments on this change.

Change subject: Kudu merge: Consolidate checkTypeCompatibility()
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2808/1/fe/src/main/java/com/cloudera/impala/analysis/StatementBase.java
File fe/src/main/java/com/cloudera/impala/analysis/StatementBase.java:

Line 34:   public static Expr checkTypeCompatibility(
> protected non-static (unless there is a compelling reason to leave it as is
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/2808
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb3d5d8749dca340e0a6f20d17a2a4f5033a0595
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message