impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Casey Ching (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Kudu: Remove post merge TODOs that need no real work
Date Mon, 18 Apr 2016 23:18:21 GMT
Casey Ching has posted comments on this change.

Change subject: Kudu: Remove post merge TODOs that need no real work
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/2807/1/fe/src/main/java/com/cloudera/impala/analysis/BinaryPredicate.java
File fe/src/main/java/com/cloudera/impala/analysis/BinaryPredicate.java:

Line 118
> There is some similarity with SingleNodePlanner.getNormalizedEqPred(). It m
Oh I saw that before but it didn't look similar enough. I'm going to leave it as-is.


http://gerrit.cloudera.org:8080/#/c/2807/1/fe/src/main/java/com/cloudera/impala/catalog/KuduTable.java
File fe/src/main/java/com/cloudera/impala/catalog/KuduTable.java:

Line 259:         builder.add("-1");   // The API doesn't expose tablet row counts.
> The Kudu Client API ....
Done


http://gerrit.cloudera.org:8080/#/c/2807/1/fe/src/main/java/com/cloudera/impala/planner/KuduScanNode.java
File fe/src/main/java/com/cloudera/impala/planner/KuduScanNode.java:

Line 272
> Imo removing this TODO is ok because I think we'd want to do this optimizat
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/2807
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42c8120574def06727b645941bbf64cc69804120
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message