impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3317: fix crash in sorter when spilling zero-length strings
Date Fri, 15 Apr 2016 22:21:13 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-3317: fix crash in sorter when spilling zero-length strings
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2780/1/be/src/runtime/sorter.cc
File be/src/runtime/sorter.cc:

Line 827: block_size_
> is block_size_ member used anywhere else besides this DCHECK now? Assuming 
Let's also dcheck that the calculation to get block_offset fits in 32-bits (i.e. that blocksize
is less than max int).


-- 
To view, visit http://gerrit.cloudera.org:8080/2780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f64593e94d367d6b6efb61a8b86e35516f18839
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message